Changeset 720

Timestamp:

03/02/10 11:37:54 (2 years ago)

Author:

apdavison

Message:

Fixed an amazingly stupid bug when using the set() function to set a parameter to zero. I can't believe this bug has been around this long. Thanks to Lyle Muller for pointing this out.

Location:

trunk

Files:

• src/common.py (modified) (1 diff)
• test/unittests/generictests.py (modified) (1 diff)

trunk/src/common.py

@@ -365 +365 @@
     giving the parameter name, in which case val is the parameter value.
     """
-    if val:
+    if val is not None:
         param = {param:val}
     if not hasattr(cells, '__len__'):

trunk/test/unittests/generictests.py

@@ -313 +313 @@
         # an IF_curr_exp, it is not a valid parameter to be changed later.
         self.assertRaises(errors.NonExistentParameterError, sim.set, self.cells, 'syn_shape', 'alpha')
+
+    def testSetZero(self):
+        sim.set(self.cells, 'v_thresh', 0.0)
     
 # ==============================================================================